My Favorite Script (Commercial)

2»

Comments

  • Zev0Zev0 Posts: 7,089

    crosswind said:

    @Zev0

    After applying the saved Pose preset, the values in Scale of some joints are not correctly set (doubled to 200%)... probably a bug.

    JSON file is attached. Ticket has been sent as well. Thanks in adv.

    Just a note if you stack a pose preset that can happen on morphs if limits have been removed on them somehow...If you Zero pose before applying that should correct the issue, unless there is a real bug somehwere. 

  • crosswindcrosswind Posts: 6,954
    edited November 11

    Zev0 said:

    crosswind said:

    @Zev0

    After applying the saved Pose preset, the values in Scale of some joints are not correctly set (doubled to 200%)... probably a bug.

    JSON file is attached. Ticket has been sent as well. Thanks in adv.

    Just a note if you stack a pose preset that can happen on morphs if limits have been removed on them somehow...If you Zero pose before applying that should correct the issue, unless there is a real bug somehwere.

    Nope, I didn't stack the pose. The preset was just applied via Favorites Script to a freshly-loaded G8F dev load.

    I attached a Scene file down below as a test case. The issue can be simply reproduced. BTW, Always Leave Limits On is set in Preferences.

    You just save a Pose Preset from Genesis 8.1 Female - Source, then apply it on Genesis 8.1 Female - Target

    Video of Issue: https://mega.nz/file/DfISFYZJ#xhevxjpW4lFJREVZYNUfX6GSU5YlJKJ6DY3Ycvr0uL4

     

    duf
    duf
    CYY1.duf
    191K
    Post edited by crosswind on
  • Zev0Zev0 Posts: 7,089
    edited November 11

    No issue here. Can another user please try and duplicate using the provided scene file above? Thanks.

    Post edited by Zev0 on
  • crosswindcrosswind Posts: 6,954
    edited November 11

    Zev0 said:

    No issue here. Can another user please try and duplicate using the provided scene file above? Thanks.

    Thanks for the test ! I probably know the culprit ...

    1)  On my side, for instance, I select the bone - Right Forearm Bend, for some reason the Scale value there is not default 100% (screenshot 1), as well as in Pose Preset (screenshot 2)..
    2)  I Alt + Click the Scale property to reset it to default 100%, re-created a new Preset with Favorite Script, then the issue of "doubled Scale value" on Right Forearm Bend is gone. (screenshot 3)

    But then I don't understand why....

    Would you pls also check Right Forearm Bend > Scale property ? Is it a non-default 100% as well on your side.... ?

    Edit1: Then I rechecked the JSON files, in the original Preset file, there's Scale data of rForearmBend (screenshot 4), but in the newly-saved Preset file, there's no Scale data (screenshot 5). The latter gives me correct result.

    So, pls also check the saved Preset file on your side... Thanks !

    Edit2: I reset Scale values on all relevant Bones and redid the process, the issue was totally gone ~ So I guess the script might handle Scale values in a specific way... Pls dbl-check.

    SNAG-2024-11-11-025.png
    2560 x 1392 - 553K
    SNAG-2024-11-12-026.png
    2560 x 1392 - 159K
    SNAG-2024-11-12-027.png
    2560 x 1392 - 445K
    SNAG-2024-11-12-028.png
    2560 x 1392 - 190K
    SNAG-2024-11-12-029.png
    2560 x 1392 - 188K
    Post edited by crosswind on
  • takezo_3001takezo_3001 Posts: 1,974

    Zev0 said:

    No issue here. Can another user please try and duplicate using the provided scene file above? Thanks.

    Downloaded and firing up DS as we speak. 

  • Zev0Zev0 Posts: 7,089
    edited November 11

    crosswind said:

    Zev0 said:

    No issue here. Can another user please try and duplicate using the provided scene file above? Thanks.

    Thanks for the test ! I probably know the culprit ...

    1)  On my side, for instance, I select the bone - Right Forearm Bend, for some reason the Scale value there is not default 100% (screenshot 1), as well as in Pose Preset (screenshot 2)..
    2)  I Alt + Click the Scale property to reset it to default 100%, re-created a new Preset with Favorite Script, then the issue of "doubled Scale value" on Right Forearm Bend is gone. (screenshot 3)

    But then I don't understand why....

    Would you pls also check Right Forearm Bend > Scale property ? Is it a non-default 100% as well on your side.... ?

    Edit1: Then I rechecked the JSON files, in the original Preset file, there's Scale data of rForearmBend (screenshot 4), but in the newly-saved Preset file, there's no Scale data (screenshot 5). The latter gives me correct result.

    So, pls also check the saved Preset file on your side... Thanks !

    Edit2: I reset Scale values on all relevant Bones and redid the process, the issue was totally gone ~ So I guess the script might handle Scale values in a specific way... Pls dbl-check.

    Mine is default at 100 on my figure.

    Capture.JPG
    917 x 923 - 53K
    Post edited by Zev0 on
  • crosswindcrosswind Posts: 6,954
    edited November 11

    In Parameter Settings, I have the same data as you do but in Parameter list and Pose Preset, the end value is not pure 1 but 0.9999985 ~~ (Screenshot 1)

    @Zev0

    Edit: Here's a simple test. If I manually set Scale value to 105% on Right Forearm Bend of the Source figure, then Scale value will be set as 205% on Right Forearm Bend of the Target figure... after applying the Preset via Favorite Script. (Screeshot 2)

    So, I think you can reproduce this issue in such a way and I believe there must be a wrong calculation for setting Scale value in your Script ~~ It seems the logic is that default or end Value 100% is added by raw Value 105% ... which results in wrongly-set 205%.

    SNAG-2024-11-12-030.png
    2007 x 1374 - 397K
    SNAG-2024-11-12-031.png
    2015 x 1293 - 412K
    Post edited by crosswind on
  • takezo_3001takezo_3001 Posts: 1,974

    I made a mistake and didn't mention earlier that it was G9 that was having its correctives zeroed along with the zero morphs tick box… So after some tests, it seems that G9 is indeed having it's corrective morphs being zeroed along with the zero morphs checkbox!

    I also see that crossfire has found the issue with G8.1, I'll see if G8.1 is having the same issue as G9…

    Nope, G8.1 remains unscathed, it was indeed G9 that was having its corrective morphs reset!

     

    MFS_G9 ERROR 2.png
    552 x 520 - 48K
    MFS_G9 ERROR 6.png
    2063 x 778 - 256K
    MFS_G9 ERROR 4.png
    554 x 502 - 48K
    MFS_G9 ERROR 7.png
    2007 x 768 - 251K
    MFS_G8.1 ERROR 1.png
    2091 x 865 - 295K
    MFS_G8.1 ERROR 2.png
    560 x 505 - 42K
    MFS_G8.1 ERROR 3.png
    2003 x 869 - 288K
    MFS_G8.1 ERROR 4.png
    549 x 506 - 42K
  • Zev0Zev0 Posts: 7,089

    Confirmed corrective morphs on g9 are going wonky...Will sort it out. G8 on the other hand works fine unless another user can duplicate the problem.

  • crosswindcrosswind Posts: 6,954

    Thank you takezo for the testing ! I will do another round of test after getting up, haha ~ devil

  • takezo_3001takezo_3001 Posts: 1,974

    Zev0 said:

    Confirmed corrective morphs on g9 are going wonky...Will sort it out. G8 on the other hand works fine unless another user can duplicate the problem.

     Cool, I'm glad to read that, thankfully it seems to have an easy solution, at least for myy non-coding eyes...

    crosswind said:

    Thank you takezo for the testing ! I will do another round of test after getting up, haha ~ devil

    Sure thing, have a great sleep! 

  • gramgram Posts: 19

    I've had this same issue happen on a Genesis 3 female figure, can you maybe check that as well?

  • bicc39bicc39 Posts: 589

    Works great, saves time.......Thank you!!

  • Zev0Zev0 Posts: 7,089

    takezo_3001 I sent you a pm.

  • takezo_3001takezo_3001 Posts: 1,974
    edited November 15

    Zev0 said:

    takezo_3001 I sent you a pm.

    Checking it now, thanks! 

    EDIT: Yep, it works!

    Post edited by takezo_3001 on
  • Zev0Zev0 Posts: 7,089
    Will submit update...Problem was the property 'body_ctrl_basejointcorrectives' was sneaking through and getting zeroed out.
  • takezo_3001takezo_3001 Posts: 1,974

    Zev0 said:

    Will submit update...Problem was the property 'body_ctrl_basejointcorrectives' was sneaking through and getting zeroed out.

     Cool, I'm glad you got it sorted, pesky little bug never stood a chance! ;^)

  • Zev0Zev0 Posts: 7,089
    edited November 15

    [Stuff] like this always happens...Specially if a product is multi generational....Specifically with how the auto correction system works...But ye..Glad it was an easy fix thanks to your help:)

    Post edited by Richard Haseltine on
  • crosswindcrosswind Posts: 6,954

    @Zev0

    Could you reproduce the issue I sent the ticket for ?

    Here's a video to show how to reproducet it, just in case.... https://mega.nz/file/7SoGQRxI#95mAKYUgcSgYw5sPsr_JcH-MJYdULiTdWJ6gJZ-CviY

  • PlatnumkPlatnumk Posts: 668

    For some reason I can't even get the script to work 

    2024-11-17 01:03:04.814 [INFO] :: Loading script: /Volumes/DAZ3D Library/My DAZ 3D Library/Scripts/Zev0/My Favorite Script/My Favorite Script.dse
    2024-11-17 01:03:04.898 [DEBUG] :: #MFS: d98749c1-215c-4968-9e28-74c4ffa15e0e
    2024-11-17 01:03:04.898 [DEBUG] :: 
    #MFS:
    ////////////////////////////////////////////////////////////
    ////  Initializing My Favorite Script...#cbO3kT
    ////////////////////////////////////////////////////////////

    2024-11-17 01:03:05.032 [DEBUG] :: #MFS: #pOJe2U: Script General Info:
    2024-11-17 01:03:05.032 [DEBUG] ::    Script Version: 1.0 (Dev 13)
       Style: Darkside
       Support Thread: https://www.daz3d.com/forums/discussion/700931/place-holder-thread-commercial
       Selected Figure: Genesis9
       Saving Presets To (#i5oJ9Q): /Users/danielwright/Library/Application Support/DAZ 3D/Studio4/My Favorite Script/Genesis9
       OS: macOS Sequoia 15.0.1
       Bit Architecture: 64
       DS Version: 4.23.0.1
       DS Release Cycle: General Release
       Script: /Volumes/DAZ3D Library/My DAZ 3D Library/Scripts/Zev0/My Favorite Script/My Favorite Script.dse

    2024-11-17 01:03:05.032 [DEBUG] :: #MFS: #T0uOBx: Loading Presets Directory from disk...
    2024-11-17 01:03:05.033 [DEBUG] :: #MFS: #wfn4zs: Reading directory file: /Users/danielwright/Library/Application Support/DAZ 3D/Studio4/My Favorite Script/Genesis9/_PresetList.json
    2024-11-17 01:03:05.033 [DEBUG] :: #MFS: #V0MkQt: No directory file found. Exiting.
    2024-11-17 01:03:05.033 [DEBUG] :: #MFS: #qem7UI: No preset directory file loaded.
    2024-11-17 01:03:05.035 [DEBUG] :: #MFS: #wEHMDa: Creating preset list dialog box...
    2024-11-17 01:03:05.035 [DEBUG] :: #MFS: #EQknB4: Defining widgets...
    2024-11-17 01:03:05.045 [DEBUG] :: #MFS: #nonkDr: Laying out widgets...
    2024-11-17 01:03:05.060 [WARNING] :: Script Error: Line 359
    2024-11-17 01:03:05.060 [WARNING] :: ReferenceError: Can't find variable: getRscPath
    2024-11-17 01:03:05.060 [WARNING] :: Stack Trace:
        <anonymous>()@/Volumes/DAZ3D Library/My DAZ 3D Library/Scripts/Zev0/My Favorite Script/My Favorite Script.dse:359
    2024-11-17 01:03:05.064 [INFO] :: Error in script execution: /Volumes/DAZ3D Library/My DAZ 3D Library/Scripts/Zev0/My Favorite Script/My Favorite Script.dse

  • takezo_3001takezo_3001 Posts: 1,974

    Zev0 said:

    [Stuff] like this always happens...Specially if a product is multi generational....Specifically with how the auto correction system works...But ye..Glad it was an easy fix thanks to your help:)

    Anytime, and thanks for the magnificent scripts! 

     
Sign In or Register to comment.